From 8f1c7d47ec418fbaf883570e647c970479dbb094 Mon Sep 17 00:00:00 2001 From: sjat Date: Wed, 17 Jun 2026 17:49:47 +0200 Subject: [PATCH] fix(reverse_proxy,netbird_coordinator): create scaffold dirs in check mode Add check_mode: false to the state:directory base_dir tasks so that 'make check' on a brand-new compose service role creates the scaffold during --check and the rest of the dry-run (templates + docker_compose_v2 up) can be evaluated instead of failing on a missing project_src. The directive is inert under a normal converge (incl. Molecule + its tagged second converge), so role tests are unchanged. Consumes the 2026-06-16 signal in docs/FRICTION.md. Co-Authored-By: Claude Opus 4.8 (1M context) --- roles/netbird_coordinator/tasks/main.yml | 2 ++ roles/reverse_proxy/tasks/main.yml | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/roles/netbird_coordinator/tasks/main.yml b/roles/netbird_coordinator/tasks/main.yml index 1cd8e3d..31b25e3 100644 --- a/roles/netbird_coordinator/tasks/main.yml +++ b/roles/netbird_coordinator/tasks/main.yml @@ -4,6 +4,8 @@ path: "{{ netbird_coordinator__base_dir }}" state: directory mode: "0750" + # create the scaffold even in --check so dry-run can evaluate templates + compose (idempotent mkdir) + check_mode: false tags: [config] - name: Render the combined server config diff --git a/roles/reverse_proxy/tasks/main.yml b/roles/reverse_proxy/tasks/main.yml index a89fedc..30f7104 100644 --- a/roles/reverse_proxy/tasks/main.yml +++ b/roles/reverse_proxy/tasks/main.yml @@ -4,6 +4,8 @@ path: "{{ reverse_proxy__base_dir }}" state: directory mode: "0750" + # create the scaffold even in --check so dry-run can evaluate templates + compose (idempotent mkdir) + check_mode: false tags: [config] - name: Ensure the Caddy config directory exists @@ -11,6 +13,8 @@ path: "{{ reverse_proxy__base_dir }}/caddy" state: directory mode: "0750" + # create the scaffold even in --check so dry-run can evaluate templates + compose (idempotent mkdir) + check_mode: false tags: [config] # Render into a directory that is bind-mounted whole (./caddy -> /etc/caddy). Mounting