From bf9ce95e1e85d0d41b550d435a89b6f48b91c745 Mon Sep 17 00:00:00 2001 From: sjat Date: Sat, 30 May 2026 19:35:11 +0200 Subject: [PATCH] Fix make new-role: brace expansion fails under dash The mkdir used shell brace expansion {tasks,handlers,...}, which /bin/sh (dash) does not support, so new-role created one literally-named dir and then errored. make new-role had never worked on this host. Use explicit mkdir paths. Co-Authored-By: Claude Opus 4.8 (1M context) --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 3322a66..190de22 100644 --- a/Makefile +++ b/Makefile @@ -146,7 +146,9 @@ new-role: ifndef NAME $(error NAME is required: make new-role NAME=) endif - mkdir -p roles/$(NAME)/{tasks,handlers,defaults,templates,files,meta,molecule/default} + mkdir -p roles/$(NAME)/tasks roles/$(NAME)/handlers roles/$(NAME)/defaults \ + roles/$(NAME)/templates roles/$(NAME)/files roles/$(NAME)/meta \ + roles/$(NAME)/molecule/default echo "---" > roles/$(NAME)/tasks/main.yml echo "---" > roles/$(NAME)/handlers/main.yml echo "---" > roles/$(NAME)/defaults/main.yml